Bad shock symptoms

Been noticing some noises coming from the front whenever I brake or roll over speed bumps and even when I turn sometimes going slow for about a year now. Almost like a crunching sound. Also found out that increased braking distance, front end dipping while braking, and poor stability control are common symptoms of old shocks. Also of which I have been experiencing. Saw a shop poster today that said shocks should be replaced every 50k miles. True? False? I got my truck and installed bilstein 5100 levelkit/shocks at 200k, I now have 250k.. Is that poster correct?? The mileage numbers and symptoms seem accurate. Just got a steering/suspension diognostic done and they said they found nothing?!
Has anyone else experienced this?
Anything helps. Thanks

 

Wheel bearing.
Ball joints.
Shocks are typically leaking and bouncy.

 

If you haven’t had any steering/suspension parts replaced inthat mileage, you should have replaced most of it by now anyway...

Balljoints, bushings, tie rod ends (inner and outer), shock, and probably even springs. ALL that should be replaced anyway. Ball joints especially.